aws / aws-app-mesh-roadmap

AWS App Mesh is a service mesh that you can use with your microservices to manage service to service communication
Apache License 2.0
347 stars 25 forks source link

Feature Request: Release Envoy v1.25.4 #459

Closed suniltheta closed 1 year ago

suniltheta commented 1 year ago

The Envoy team released v1.25.4: https://github.com/envoyproxy/envoy/releases/tag/v1.25.4.

We should update the App Mesh Envoy Container Image to v1.25.4.

suniltheta commented 1 year ago

The images have been released:

We'll keep this issue open as we update the recommended image our other projects (e.g. aws/aws-app-mesh-controller-for-k8s), examples, and documentation.

suniltheta commented 1 year ago

Thanks to Envoy maintainers & community this image provides fixes for the following CVEs:

Refer: https://github.com/envoyproxy/envoy/security/advisories

suniltheta commented 1 year ago

⚠️⚠️ Caution while upgrading to this image ⚠️⚠️

A CVE-2023-27487 fix (commit: 4a8cc2e) made in Envoy will sanitizing header x-envoy-original-path correctly. So, expect a change in the header value when received by the upstream services. If you think this vulnerability condition is not applicable in your scenario and you want to disable the feature envoy.reloadable_features.sanitize_original_path then you can set the env variable in Envoy container ENVOY_SANITIZE_ORIGINAL_PATH to false (Context: https://github.com/aws/amazon-ecs-service-connect-agent/pull/15).

suniltheta commented 1 year ago

The above CVE fix was updated to sanitize the header only on edge Envoy proxy since v1.25.5 release on Envoy. So in Envoy v1.26.4 release the behavior will not change unless the Envoy is determined as edge proxy.