search

aws / aws-app-mesh-roadmap

AWS App Mesh is a service mesh that you can use with your microservices to manage service to service communication
Apache License 2.0
347 stars 25 forks source link

Bug: fix deprecation warning 'envoy.config.route.v3.WeightedCluster.total_weight' from file route_components.proto #478

Open tnsardesai opened 1 year ago

tnsardesai commented 1 year ago

Summary What are you observing that doesn't seem right? Seeing deprecation following warning

[2023-08-04 19:40:58.318][22][warning][misc] [source/common/protobuf/message_validator_impl.cc:21] Deprecated field: type envoy.config.route.v3.WeightedCluster Using deprecated option 'envoy.config.route.v3.WeightedCluster.total_weight' from file route_components.proto. This configuration will be removed from Envoy soon. Please see https://www.envoyproxy.io/docs/envoy/latest/version_history/version_history for details. If continued use of this field is absolutely necessary, see https://www.envoyproxy.io/docs/envoy/latest/configuration/operations/runtime#using-runtime-overrides-for-deprecated-features for how to apply a temporary and highly discouraged override.

Steps to Reproduce What are the steps you can take to reproduce this issue? Use weighted routes

Are you currently working around this issue? How are you currently solving this problem? Ignoring the logs

Additional context Anything else we should know? Envoy docs https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/route/v3/route_components.proto#config-route-v3-weightedcluster - This field is now deprecated, and the client will use the sum of all cluster weights. It is up to the management server to supply the correct weights.

Deprecation warning shows with envoy public.ecr.aws/appmesh/aws-appmesh-envoy:v1.24.0.0-prod. I haven't tried it with latest. Btw https://github.com/aws/aws-app-mesh-roadmap/issues/438 this other deprecation warning is still there.

dhilgarth commented 7 months ago

I can confirm that this also happens with 1.27.2.0