aws / aws-application-networking-k8s

A Kubernetes controller for Amazon VPC Lattice
https://www.gateway-api-controller.eks.aws.dev/
Apache License 2.0
175 stars 50 forks source link

Fix target group discovery logic #587

Closed solmonk closed 10 months ago

solmonk commented 10 months ago

What type of PR is this?

bug

Which issue does this PR fix:

What does this PR do / Why do we need it:

Fixes target group discovery logic that may cause service exports from other clusters are not shown.

I think this VPC-based filtering logic got into during the TG performance optimization. I don't think this adds a lot of performance value anyways so I completely removed it. List() call is currently used in two places:

If an issue # is not available please add repro steps and logs from aws-gateway-controller showing the issue:

Testing done on this change:

Unit testing and manual cross-cluster testing that verifies traffic.

Automation added to e2e:

Will this PR introduce any new dependencies?:

Will this break upgrades or downgrades. Has updating a running cluster been tested?:

Does this PR introduce any user-facing change?:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

allamand commented 10 months ago

I will be happy to test this

zijun726911 commented 10 months ago

@allamand we will release a new version helm chart and artifact soon to include this fix

allamand commented 10 months ago

I’ve tested and it works as expected. Thanks for the quick patch and release