aws / aws-application-networking-k8s

A Kubernetes controller for Amazon VPC Lattice
https://www.gateway-api-controller.eks.aws.dev/
Apache License 2.0
175 stars 50 forks source link

Optimize docker build and support multi-arch (ARM64) #598

Closed solmonk closed 9 months ago

solmonk commented 9 months ago

What type of PR is this?

feature

Which issue does this PR fix:

579 - should be able to support ARM64 next release.

What does this PR do / Why do we need it: Fixed dockerfile to support multiarch and optimized build to utilize cache

If an issue # is not available please add repro steps and logs from aws-gateway-controller showing the issue:

Testing done on this change: Tested using personal fork

Automation added to e2e:

Will this PR introduce any new dependencies?:

Will this break upgrades or downgrades. Has updating a running cluster been tested?:

Does this PR introduce any user-facing change?:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

zijun726911 commented 9 months ago

Are different arch images reside in the same repo? how user select different arch to deploy helm chart to their k8s cluster? can we mention it in our doc?

solmonk commented 9 months ago

All platforms should be part of the same image. I believe users don't need to select anything, k8s picks it up based on the platform.