aws / aws-application-networking-k8s

A Kubernetes controller for Amazon VPC Lattice
https://www.gateway-api-controller.eks.aws.dev/
Apache License 2.0
175 stars 50 forks source link

Fix for Makefile webhook secrets #608

Closed erikfuller closed 9 months ago

erikfuller commented 9 months ago

What type of PR is this? bug

Which issue does this PR fix: https://github.com/aws/aws-application-networking-k8s/issues/596

What does this PR do / Why do we need it: The current Makefile commands for generating the webhook cert aren't quite right. It was working before I added the rm line because the files already existed. This fixes failures when running build-deploy.

Testing done on this change: Ran make build-deploy in "clean" directories, confirmed correct patching.

Automation added to e2e: n/a

Will this PR introduce any new dependencies?: n/a

Will this break upgrades or downgrades. Has updating a running cluster been tested?: n/a

Does this PR introduce any user-facing change?: no

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.