aws / aws-application-networking-k8s

A Kubernetes controller for Amazon VPC Lattice
https://www.gateway-api-controller.eks.aws.dev/
Apache License 2.0
157 stars 48 forks source link

Integrate helm chart with Cert-Manager CA Injector #618

Open phmcder opened 2 months ago

phmcder commented 2 months ago

The current Helm chart requires the passing of TLS certificate values. Then it will create the certificate secret and hard code the caCert value for the webhook.

Other helm deployments have the option of using Cert-Manager to manage the webhook certificates using the CA Injector. This automates the updating of the webhook caCert value. https://cert-manager.io/docs/concepts/ca-injector/

External-Secrets has a helm chart that supports this: Here the cert-manager.io/inject-ca-fromannotation is being set on line 12 (https://github.com/external-secrets/external-secrets/blob/main/deploy/charts/external-secrets/templates/validatingwebhook.yaml)

Currently, I am blocked from implementing this because

Can Cert-Manager support be added to the Helm?

Thanks

erikfuller commented 1 month ago

Hi @phmcder, thanks for opening this issue. What's in the AWS load balancer controller would adapt well to our Helm chart (webhook annotation, secret/cert, and volume).

Adding cert-manager support makes sense, though the timeline to address would likely depend on demand. Happy to review a PR as well if you'd like to accelerate this.