search

aws / aws-application-networking-k8s

A Kubernetes controller for Amazon VPC Lattice
https://www.gateway-api-controller.eks.aws.dev/
Apache License 2.0
157 stars 48 forks source link

Update deploy.md to use IRSA instead of pod identities #645

Open gaurarpit12 opened 1 month ago

gaurarpit12 commented 1 month ago

The method explained in pod identities section is error prone and doesn't create the required resources. Hence, going for IRSA is recommended.

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it: To ensure that users use the correct methodology

If an issue # is not available please add repro steps and logs from aws-gateway-controller showing the issue:

Testing done on this change:

Automation added to e2e:

Will this PR introduce any new dependencies?:

Will this break upgrades or downgrades. Has updating a running cluster been tested?:

Does this PR introduce any user-facing change?:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

zijun726911 commented 4 weeks ago

Hi @gaurarpit12 , which step of the Pod Identities setup not work for you? could you help to share the error message? I tried on my side these steps work for me.

gaurarpit12 commented 1 week ago

@zijun726911 , The steps didn't create what is required, when using pod identities. However, IRSA works fine. Hence, IRSA should be the default one to be used