search

aws / aws-application-networking-k8s

A Kubernetes controller for Amazon VPC Lattice
https://www.gateway-api-controller.eks.aws.dev/
Apache License 2.0
175 stars 50 forks source link

Miss to add the DISABLE_TAGGING_SERVICE_API envvariable in the environment.md, helm/templates/deployment.yaml and helm/values.yaml #653

Open zijun726911 opened 5 months ago

zijun726911 commented 5 months ago

In this PR we add the DISABLE_TAGGING_SERVICE_API env variable https://github.com/aws/aws-application-networking-k8s/pull/627/files

However we miss to add corresponding env variable in the environment.md, helm/templates/deployment.yaml and helm/values.yaml and the users cannot pass that env variable to start the helm chart.

https://github.com/aws/aws-application-networking-k8s/blob/933a07f6eed8b192b2b73ed73c4ecd47a2e3d551/helm/values.yaml#L80

https://github.com/aws/aws-application-networking-k8s/blob/553422e886713c9ddf2aed29143db1dfe2e840e7/helm/templates/deployment.yaml#L97

https://github.com/aws/aws-application-networking-k8s/blob/1862bef9b5f4956b08f34b80723464a99682f542/docs/guides/environment.md?plain=1#L90