aws / aws-aspnet-cognito-identity-provider

ASP.NET Core Identity Provider for Amazon Cognito
https://aws.amazon.com/developer/language/net/
Apache License 2.0
215 stars 89 forks source link

Simplify constructor cast #120

Closed assyadh closed 3 years ago

assyadh commented 5 years ago

See the comments on https://github.com/aws/aws-aspnet-cognito-identity-provider/pull/119

In multiple constructors, we are doing:

 if (userManager is CognitoUserManager<TUser>)
                _userManager = userManager as CognitoUserManager<TUser>;

We could just hard cast the second instruction.

github-actions[bot] commented 3 years ago

We have noticed this issue has not recieved attention in 1 year. We will close this issue for now. If you think this is in error, please feel free to comment and reopen the issue.