search

aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code
https://aws.amazon.com/cdk
Apache License 2.0
11.5k stars 3.85k forks source link

[aws-eks] Helm registry login #11031

Open J11522 opened 3 years ago

J11522 commented 3 years ago

Currently, there is no way of accessing a private helm registry. By adding support for the helm registry login command, we can consume private charts in the same way as on a local cluster.

Use Case

In order to consume and deploy a private helm chart into my EKS cluster.

Proposed Solution

I would propose specifying a secret or secret resolve string in the HelmChartOptions This is then passed to the kubectl handler Lambda function

Prior to calling upgrade I would check if a secret is passed. This needs to be resolved using the secrets manager and the actual login data is passed to the helm registry login command

This is a :rocket: Feature Request

eladb commented 3 years ago

I think this makes sense and we would love to accept a contribution.

mburket commented 2 years ago

Facing the same issue for private helm/chart repo.

rcooper85 commented 1 year ago

I'm facing this issue when trying to pull helm charts I've created and stored in a Gitlab private registry.

ethanrucinski commented 1 year ago

Hey I was able to submit a pull request with code that worked for me to resolve this: https://github.com/aws/aws-cdk/pull/23068

Please let me know if anybody has feedback!