(synthetics): Add new runtimes

aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code

https://aws.amazon.com/cdk

Apache License 2.0

11.52k stars 3.86k forks source link

(synthetics): Add new runtimes #11870

Closed flochaz closed 3 years ago

flochaz commented 3 years ago

AWS Cloudwatch synthetics now support two newer version of the nodejs runtime and one new python one.

Would be great to have it available in the aws-synthetics construct

Use Case

Use latest Cloudwatch synthetics feature

Proposed Solution

Add new runtimes ref

[x] :wave: I may be able to implement this feature request
[ ] :warning: This feature might incur a breaking change

This is a :rocket: Feature Request

NetaNir commented 3 years ago

commented on the PR, adding here for visibility.

The Canary module assume the runtime is always Nodejs, and enforce the below:

The Canary code does include node_moduels folder. See synthetics docs: https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Synthetics_Canaries_WritingCanary_Nodejs.html

The handler file is named index.handler

Before we introduce Python as runtime we need to address it. Im happy to accept a PR which adds the new node runtime in the meantime https://github.com/aws/aws-cdk/pull/11866#pullrequestreview-545323050

github-actions[bot] commented 3 years ago

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.