aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code
https://aws.amazon.com/cdk
Apache License 2.0
11.51k stars 3.85k forks source link

(aws-ses): Support domains #13714

Open amchelle opened 3 years ago

amchelle commented 3 years ago

This issue was repurposed as a feature request to support SES Domains, as well the ability to configure notifications.

Original report was

:question: General Issue

The Question

I am trying to edit the notification configuration of a domain in SES for bounce and complaint notifications to be sent to a SNS Topic. It is available through the console, but I can't figure out if it is possible through the cdk.

image

iliapolo commented 3 years ago

@amchelle SES Domains are currently not supported by CDK, nor by CloudFormation.

A good rule of thumb is that if a feature is supported by CloudFormation, it will always be supported by CDK, if not, it might be supported by CDK, but not guaranteed.

I'll mark this as a feature request pending either CloudFormation support, or a custom resource implementation.

iliapolo commented 3 years ago

See https://github.com/aws-cloudformation/aws-cloudformation-coverage-roadmap/issues/583

mooyoul commented 3 years ago

Hello there, I've created a package for validating domain: https://github.com/mooyoul/aws-cdk-ses-domain-identity Currently It does not handle notification stuffs, but I can help this if you still need this functionality.

Anyway, It would be great if Domain-wide configuration can be provided as "official" CDK package - Is there any opportunity to merge this to upstream?

iliapolo commented 3 years ago

@mooyoul You package can be merged upstream if we see strong evidence the community needs it.

I suggest you open an issue and describe exactly what you package supports, then you can reach out to the cdk.dev community on Slack to solicit support for prioritization.

project0 commented 3 years ago

Just if someone else is looking for a solution without any 3rd party library, its possible to use the AWS CDK custom resource package. An example is even documented ;-) https://github.com/aws/aws-cdk/tree/master/packages/%40aws-cdk/custom-resources#verify-a-domain-with-ses