search

aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code
https://aws.amazon.com/cdk
Apache License 2.0
11.62k stars 3.91k forks source link

(aws-synthetics): Add support for Playwright based Canaries?.. #13949

Closed busticated closed 3 years ago

busticated commented 3 years ago

hey there :wave:

i'm very much enjoying AWS Synthetics Canaries here. One request: I'd love to be able to run Canaries built on top of playwright - https://github.com/microsoft/playwright | https://playwright.dev

Use Case

Ability to run tests under browsers other than Chrome / Chromium (e.g. Firefox)

Proposed Solution

support and expose the playwright library within the Canary runtime environment in addition to or in place of puppeteer.

This is a :rocket: Feature Request

NetaNir commented 3 years ago

I think this is a feature request for AWS synthetics.

busticated commented 3 years ago

I think this is a feature request for AWS synthetics.

it is! is that not this? 👉 https://github.com/aws/aws-cdk/tree/master/packages/%40aws-cdk/aws-synthetics

NetaNir commented 3 years ago

This is the AWS CDK construct built on top of the service (in this case, AWS synthetics). If the capability does not exist on the service and in its's CloudFormation resource, then it cannot be provisioned via the CDK. See the service docs: https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Synthetics_Canaries.html

busticated commented 3 years ago

well, fwiw i guess 👍

github-actions[bot] commented 3 years ago

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.