search

aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code
https://aws.amazon.com/cdk
Apache License 2.0
11.63k stars 3.91k forks source link

(aws-wafv2): customResponseBodies is not present on CfnWebACLProps #14199

Closed mschenke closed 3 years ago

mschenke commented 3 years ago

:question: CfnWebACLProps missing CustomResponseBodies

The Question

CloudFormation documentation shows support for CustomResponseBodies here https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-wafv2-webacl.html#cfn-wafv2-webacl-customresponsebodies

This is missing from the CfnWebACL

mschenke commented 3 years ago

CustomResponseBody seems to be present here: https://d1uauaxba7bl26.cloudfront.net/latest/gzip/CloudFormationResourceSpecification.json

Not sure why it isn't in CfnWebACLProps

njlynch commented 3 years ago

Hi @mschenke .

CustomResponseBodies was added to the CloudFormation specification in version 32.0.0. The latest merged into the CDK is currently 31.1.0. There is a pending pull request to merge in version 33.0.0, which will bring in the new properties: https://github.com/aws/aws-cdk/pull/14168

Once the above is merged in and released, CfnWebACL will be updated. I'm going to close this issue in favor of that one, please mention me or post in that PR if you have any related follow-ups!

github-actions[bot] commented 3 years ago

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.