search

aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code
https://aws.amazon.com/cdk
Apache License 2.0
11.41k stars 3.8k forks source link

(aws-ec2): AWS::EC2::FlowLog is incorrectly considered taggable in some regions #15277

Closed tiefps closed 1 year ago

tiefps commented 3 years ago

:question: General Issue

The Question

Adding flowlogs to a VPC (vpc.addFlowLog) causes tags to be added to the AWS::EC2::FlowLog resource, however FlowLog doesn't support tags in the us-iso-east-1 and us-isob-east-1 regions.

Error AWS::EC2::FlowLog Encountered unsupported property Tags

Environment

Other information

peterwoodworth commented 3 years ago

I'm sorry for the experience here @tiefps,

It looks like the Tags property is set so that the flow log name can be set.

I'm not familiar with the -isob- regions, but if the issue is that AWS::EC2::FlowLog doesn't support tags then that's a Cloudformation issue. You can submit an issue here if an issue for this doesn't exist already

peterwoodworth commented 3 years ago

Closing due to staleness, ping me if you still need help with this

github-actions[bot] commented 3 years ago

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.

tiefps commented 2 years ago

@njlynch - This issue should still be open as it is unresolved.

peterwoodworth commented 2 years ago

Reopened and working with customer in DMs

peterwoodworth commented 2 years ago

Closing in favor of #16373

github-actions[bot] commented 2 years ago

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.

peterwoodworth commented 2 years ago

Reopening to potentially fix in our region-info package

corymhall commented 1 year ago

I'm going to close this in favor of #16373. I think it makes more sense to try and solve this issue in a way that would apply to all resources and not address a single one at a time.

In general the solution to these type of things is to handle it in your CDK app. For tags that would mean filtering out certain resource types.

Tags.of(this).add('Key', 'Value', { excludeResourceTypes: ['AWS::EC2::FlowLog'] });
github-actions[bot] commented 1 year ago

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.