flemjame-at-amazon
commented
3 years ago Deeper digging uncovered more instances of substitutions not happening:
"DLTDLTTemplateCognitoUserPoolE00202A7": {
"Type": "AWS::Cognito::UserPool",
"Properties": {
"AdminCreateUserConfig": {
"AllowAdminCreateUserOnly": true,
"InviteMessageTemplate": {
"EmailMessage": {
"Fn::Sub": "<p>You are invited to join the Distribution Load Testing Solution.</p>\n<p>Username: <strong>{username}</strong></p>\n<p>Password: <strong>{####}</strong></p>\n<p>Console: <strong>https://${ConsoleCloudFront.DomainName}/<
/strong></p>\n" ## Should be ${DLTDLTTemplateConsoleCloudFrontCEAF1B6F} instead
},"DLTDLTTemplateTaskRunnerStepFunctionsAC1DF482": {
"Type": "AWS::StepFunctions::StateMachine",
"Properties": {
"RoleArn": {
"Fn::GetAtt": "DLTDLTTemplateTaskRunnerStepFunctionsRole97DD7EF6.Arn"
},
"DefinitionString": {
"Fn::Sub": "{
"Comment": "Distributed Load Testing on AWS Task Runner",
"StartAt": "Check ECR is ready",
"States": {
"Check ECR is ready": {
"Type": "Task",
"Resource": "${DLTDLTTemplateEcrChecker53762B06.Arn}",
"InputPath": "$",
"OutputPath": "$",
"Next": "ECR is ready?"
},
"ECR is ready?": {
"Type": "Choice",
"Choices": [
{
"Variable": "$.ecrReady",
"BooleanEquals": true,
"Next": "Check running tests"
}
],
"Default": "Wait 1 minute - ECR ready"
},
"Wait 1 minute - ECR ready": {
"Comment": "Wait 1 minute to check ECR readiness",
"Type": "Wait",
"Seconds": 60,
"Next": "Check ECR is ready"
},
"Check running tests": {
"Type": "Task",
"Resource": "${TaskStatusChecker.Arn}", ## Should be DLTDLTTemplateTaskStatusChecker327377ED.Arn
"InputPath": "$",
"OutputPath": "$",
"Next": "No running test?"
},
"No running test?": {
"Type": "Choice",
"Choices": [
{
"Variable": "$.isRunning",
"BooleanEquals": false,
"Next": "Run workers"
}
],
"Default": "Test is still running"
},
"Test is still running": {
"Type": "Fail",
"Error": "TestAlreadyRunning",
"Cause": "The same test is already running."
},
"Run workers": {
"Type": "Task",
"Resource": "${TaskRunner.Arn}", ## Should be DLTDLTTemplateTaskRunner8A4D7569.Arn
"InputPath": "$",
"OutputPath": "$",
"Next": "All workers launched?"
},
"All workers launched?": {
"Type": "Choice",
"Choices": [
{
"Variable": "$.isRunning",
"BooleanEquals": false,
"Next": "Cancel Test"
},
{
"Variable": "$.taskRunner.runTaskCount",
"NumericEquals": 1,
"Next": "Wait 1 minute - worker status"
},
{
"Variable": "$.taskRunner.runTaskCount",
"NumericEquals": 0,
"Next": "Wait 1 minute - task status"
}
],
"Default": "Run workers"
},
"Cancel Test": {
"Type": "Task",
"Resource": "${TaskCanceler.Arn}", ## Should be DLTDLTTemplateTaskCanceler93036AAF.Arn
"InputPath": "$",
"ResultPath": null,
"OutputPath": "$",
"Next": "Parse result"
},
"Wait 1 minute - worker status": {
"Comment": "Wait 1 minute to check task status again",
"Type": "Wait",
"Seconds": 60,
"Next": "Check worker status"
},
"Check worker status": {
"Type": "Task",
"Resource": "${TaskStatusChecker.Arn}", ## Should be DLTDLTTemplateTaskStatusChecker327377ED.Arn
"InputPath": "$",
"OutputPath": "$",
"Next": "All workers running?"
},
"All workers running?": {
"Type": "Choice",
"Choices": [
{
"Variable": "$.numTasksRunning",
"NumericEqualsPath": "$.scenario.taskCount",
"Next": "Run leader task"
},
{
"Variable": "$.isRunning",
"BooleanEquals": false,
"Next": "Parse result"
}
],
"Default": "Wait 1 minute - worker status"
},
"Run leader task": {
"Type": "Task",
"Resource": "${TaskRunner.Arn}", ## Should be DLTDLTTemplateTaskRunner8A4D7569.Arn
"InputPath": "$",
"OutputPath": "$",
"Next": "Wait 1 minute - task status"
},
"Wait 1 minute - task status": {
"Comment": "Wait 1 minute to check task status again",
"Type": "Wait",
"Seconds": 60,
"Next": "Check task status"
},
"Check task status": {
"Type": "Task",
"Resource": "${TaskStatusChecker.Arn}", ## Should be DLTDLTTemplateTaskStatusChecker327377ED.Arn
"InputPath": "$",
"OutputPath": "$",
"Next": "All tasks done?"
},
"All tasks done?": {
"Type": "Choice",
"Choices": [
{
"Variable": "$.isRunning",
"BooleanEquals": false,
"Next": "Parse result"
}
],
"Default": "Wait 1 minute - task status"
},
"Parse result": {
"Type": "Task",
"Resource": "${ResultsParser.Arn}", ## Should be DLTDLTTemplateResultsParserA3D2FE0A
"Next": "Done"
},
"Done": {
"Type": "Pass",
"End": true
}
}
}
"
},At a glance, a commonality appears to be the use of Sub!
skinny85
github-actions[bot]
I thought it would be a neat idea to use AWS Distributed Load Testing through CDK, so I downloaded the template (link) and used CfnInclude like so.
However, when I tried to deploy the stack, I got the following error:
Template format error: Unresolved resource dependencies [ScenariosBucket, Api] in the Resources block of the templateI've attached the original template file (the one I am CfnInclude-ing) and the synthesized template (after being CfnInclude-d) to this issue.
distributed-load-testing-on-aws.template.txt ## This template is vended by AWS and works really well synthesized-template-after-cfninclude.template.txt ## This template is the above template, but CfnInclude-d, and fails when trying to create a stack.
In the original template there are two resources, called
ScenariosBucketandApi. I don't preserve logical IDs, so I expect them all to change, and sure enough they did. They changed to:Before:
After
Before:
After:
However, there was a missed reference for each of these, which wasn't converted to the new logical ID, and which is causing the stack to fail to create. It is a custom resource, but I am not sure why these failed to convert -- the custom resource has other references that did successfully convert to new logical ids.
Original:
After CfnInclude:
Reproduction Steps
What did you expect to happen?
I should be able to create a stack using my template that has the CfnInclude in it.
What actually happened?
Got a CloudFormation error upon trying to create the stack:
Template format error: Unresolved resource dependencies [ScenariosBucket, Api] in the Resources block of the templateEnvironment
Other
This is :bug: Bug Report