search

aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code
https://aws.amazon.com/cdk
Apache License 2.0
11.66k stars 3.92k forks source link

(cli): re-bootstrapping wont update all tags #17406

Open Wurstnase opened 3 years ago

Wurstnase commented 3 years ago

What is the problem?

First bootstrap will create SSM parameter with tags. In our case we had publish the wrong tags and want to change the tags. Unfortunately the tags for the parameter are not updated.

Reproduction Steps

npx cdk bootstrap --tags mytag=old_value npx cdk bootstrap --tags mytag=new_value

What did you expect to happen?

All tags are updated.

What actually happened?

Nothing. Tags for the ssm parameter are unchanged.

CDK CLI Version

1.131

Framework Version

No response

Node.js Version

14.x

OS

Linux/MacOS

Language

Python

Language Version

No response

Other information

No response

rix0rrr commented 2 years ago

What actually happened?

Nothing. Tags for the ssm parameter are unchanged.

Can you be more specific?

Did nothing actually happen? As in, no tags got updated? Not those of an the S3 bucket, not those of the IAM roles?

Or did just the SSM parameter tags not get updated?

github-actions[bot] commented 2 years ago

This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

Wurstnase commented 2 years ago

I will check it again what happens.

What I've remember, only the tags for the SSM are not updated.

Wurstnase commented 2 years ago

Or did just the SSM parameter tags not get updated?

Yes, SSM parameter are not updated. I just checked it with CDK 2.10 bootstrapping. New tags are not added nor old tags are updated.

comcalvi commented 2 months ago

CDK applies those tags to the bootstrap stack. CFN should apply the tags to every resource in the stack, and it seems that it does not.