ECS Patterns: Add RuntimePlatform to L3 Constructs

aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code

https://aws.amazon.com/cdk

Apache License 2.0

11.37k stars 3.78k forks source link

ECS Patterns: Add RuntimePlatform to L3 Constructs #18462

Open automartin5000 opened 2 years ago

automartin5000 commented 2 years ago

Description

Add this RuntimePlatform property to ECS Patterns constructs. I'm specifically interested in QueueProcessingFargateService and NetworkLoadBalancedFargateService

Use Case

I want to run Fargate containers on Graviton instances

Proposed Solution

Implement the RuntimePlatform property recently added here.

Other information

No response

Acknowledge

[ ] I may be able to implement this feature request
[ ] This feature might incur a breaking change

madeline-k commented 2 years ago

Thanks for opening this issue, @automartin5000! I'm labelling it as p2 for now, which means the CDK team won't prioritize implementing this right now. However, contributions are always welcome! Check out the contributing guide to get started.

flavioleggio commented 2 years ago

Hello @automartin5000, I am taking a look at this and I think you can specify the runtimePlatform property if you pass in a FargateTaskDefinition to the NetworkLoadBalancedFargateService constructor props, instead of a NetworkLoadBalancedTaskImageOptions. Is there any reason for that property to be also present in the NetworkLoadBalancedTaskImageOptions? I agree with you when you say that one cannot define the runtimePlatform in a QueueProcessingFargateService.

michaeldrey commented 2 years ago

Have this written up, will have a PR shortly