Open i906 opened 2 years ago
This makes great sense to me. I think we probably should fix this place and allow AssetEnvironmentFile
to pass id to the Asset class internally. Feel free to suggest any solution any any PR submission would be highly welcome here.
Opened A PR that could possibly resolve this. Not 100% sure if the implementation fits to what you were thinking @pahud but would love to hear back to see if it seems like a reasonable fix. The PR has some more information as to the rationale behind the the proposed changes. If it looks good happy rejigging all the tests!
Thanks in advance for any input :raised_hands:
Describe the bug
The use of multiple
ecs.EnvironmentFile.fromAsset()
intaskDefinition.addContainer()
resulted to an error.Expected Behavior
Able to use
ecs.EnvironmentFile.fromAsset()
multiple times in a stack.Current Behavior
Unable to synth the stack.
Reproduction Steps
Possible Solution
Modify the
Asset
ID fromEnvironmentFile
to something that is derived from the asset path.Additional Information/Context
No response
CDK CLI Version
2.33.0 (build 859272d)
Framework Version
No response
Node.js Version
v16.16.0
OS
MacOS
Language
Typescript
Language Version
3.9.10
Other information
Related PR: https://github.com/aws/aws-cdk/pull/10673