aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code
https://aws.amazon.com/cdk
Apache License 2.0
11.55k stars 3.87k forks source link

aws-cdk: make "cdk notices" show only unacknowledged notices #23078

Closed enummela-diligent closed 3 weeks ago

enummela-diligent commented 1 year ago

Describe the feature

Make it possible for cdk notices to show only the unacknowledged notices. Currently it lists "the notices that are relevant to the current CDK repository, regardless of context flags or notices that have been acknowledged" [link].

Use Case

Checking if there are any unacknowledged notices in CI checks. Example package.json:

{
  "scripts": {
    "test": "jest",
    "notices": "notices=$(cdk notices --unacknowledged-only); [ -z \"$notices\" ]",
    "ci": "npm test && npm run notices"
  }
}

Proposed Solution

One possible way to implement could be adding an --unacknowledged-only flag.

Other Information

No response

Acknowledgements

CDK version used

2.50.0 (build 4c11af6)

Environment details (OS name and version, etc.)

macOS Monterey 12.6.1

peterwoodworth commented 1 year ago

Thanks for this request, it would be nice if we supported this 🙂

I am marking this issue as p2, which means that we are unable to work on this immediately.

We use +1s to help prioritize our work, and are happy to revaluate this issue based on community feedback. You can reach out to the cdk.dev community on Slack to solicit support for reprioritization.

Check out our contributing guide if you're interested in contributing yourself - there's a low chance the team will be able to address this soon but we'd be happy to review a PR 🙂

github-actions[bot] commented 3 weeks ago

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.