aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code
https://aws.amazon.com/cdk
Apache License 2.0
11.65k stars 3.91k forks source link

EbsDeviceProps missing support for setting throughput on GP3 volumes, yet VolumeProps has support for it #24341

Closed adrabkin closed 2 months ago

adrabkin commented 1 year ago

Describe the feature

When creating and EC2 instance, and configuring a blockDevices property, this uses the BlockDeviceVolume type, which accepts an ebsDevice parameter of type EbsDeviceProps. EbsDeviceProps does not have the option to set a throughput property.

However, if you look at VolumeProps, when creating a volume separately, it does support the throughput property.

Use Case

I've seen examples where people are creating volumes outside of the blockDevices property of an Instance, then have to deal with attaching the volume.

Having the option to create a gp3 volume along with all of its configuration properties (including throughput) directly via the instance as part of the blockDevices property simplifies the deployment of an instance. iops is already an accepted property as part of EbsDeviceProps, why not throughput?

Proposed Solution

No response

Other Information

No response

Acknowledgements

CDK version used

2.66.1

Environment details (OS name and version, etc.)

OSX 12.6.3

pahud commented 1 year ago

Yes we probably should add this property in EbsDeviceOptionsBase or other interfaces. I'm making this a p2 feature request and any PR submission will be more than welcome and appreciated.

isker commented 4 months ago

I tried to fix this in #30317 but could not get a review before automation closed it. Trying again in #30716.

github-actions[bot] commented 2 months ago

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

github-actions[bot] commented 2 months ago

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.