aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code
https://aws.amazon.com/cdk
Apache License 2.0
11.72k stars 3.94k forks source link

(aws-ecs): Provide support for DeploymentAlarms on ECS Service #24344

Open neilferreira opened 1 year ago

neilferreira commented 1 year ago

Describe the feature

The ECS team recently introduced CloudWatch alarms for ECS deployments as described in https://aws.amazon.com/about-aws/whats-new/2022/12/amazon-ecs-cloudwatch-alarms-safety-deployments/

It would be great if ECS Service and ECS Fargate service could support this via constructor props

Fargate docs:

Use Case

This feature allows customers to add automated safeguards for Amazon ECS service rolling updates. You can now monitor and automatically react to changes during an Amazon ECS rolling update by using Amazon CloudWatch alarms. This enables you to more easily automate discovery and remediation for failed deployments and minimize the impact of a bad change.

Proposed Solution

Provide a props argument or property that is able to populate the DeploymentAlarms attribute on an ECS Service as per https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ecs-service-deploymentalarms.htmlcan

Other Information

No response

Acknowledgements

CDK version used

v2.66.1

Environment details (OS name and version, etc.)

MacOS

pahud commented 1 year ago

Yeah this would be an awesome feature! Is this something you are interested as a PR submission?

bvtujo commented 1 year ago

This is currently in progress with #24182; stay tuned!