aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code
https://aws.amazon.com/cdk
Apache License 2.0
11.5k stars 3.84k forks source link

aws-batch-alpha: Missing ephemeralStorage configuration #25393

Closed gael-ft closed 1 year ago

gael-ft commented 1 year ago

Describe the bug

AWS Batch using ECS Fargate should support setting the ephemeralStorage (< 200GiB).

I can't find any ways to do it currently

Expected Behavior

Having a ephemeralStorage property in EcsFargateContainerDefinition.

Current Behavior

No way to configure ephemeralStorage

Reproduction Steps

Create a new EcsJobDefinition(...) with new EcsFargateContainerDefinition(...) as container property

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.77.0 (build 06a0b19)

Framework Version

No response

Node.js Version

v16.13.0

OS

MacOS

Language

Typescript

Language Version

No response

Other information

No response

pahud commented 1 year ago

We probably can add it in EcsContainerDefinitionProps. Are you interested to submit a PR for that?

kaizencc commented 1 year ago

@sumupitchayan @daschaa i mean it looks like you both created a PR for this issue at the exact same time. But maybe Sumu was first by minutes

daschaa commented 1 year ago

@kaizencc Thanks for notifying. I'll close mine. 👍🏼

github-actions[bot] commented 1 year ago

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.