search

aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code
https://aws.amazon.com/cdk
Apache License 2.0
11.47k stars 3.83k forks source link

aws-cdk-lib.custom_resources: S3File and S3Assert examples broken links #25503

Closed dbaileyut closed 1 year ago

dbaileyut commented 1 year ago

Describe the issue

The links in custom_resources's S3File and S3Assert are broken:

S3File

Provisions an object in an S3 bucket with textual contents. See the source code for the construct(broken) and handler(broken).

S3Assert

Checks that the textual contents of an S3 object matches a certain value. The check will be retried for 5 minutes as long as the object is not found or the value is different. See the source code for the construct(broken) and handler(broken).

Links

https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.custom_resources-readme.html

khushail commented 1 year ago

Hi @dbaileyut , thanks for pointing out this bug in documentation. This should be updated.

peterwoodworth commented 1 year ago

Thanks for fixing this @khushail

github-actions[bot] commented 1 year ago

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.