aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code
https://aws.amazon.com/cdk
Apache License 2.0
11.68k stars 3.92k forks source link

RDS: Database Cluster Writer/Reader's DeleteAutomatedBackups #25948

Open argarinpauljohn opened 1 year ago

argarinpauljohn commented 1 year ago

Describe the feature

In the original instance_props, there was a delete_automated_backups property. How can we specify that in writer/readers? The rds.ClusterInstance.provisioned method doesn't seem to support that.

Related issue: https://github.com/aws/aws-cdk/issues/25898

Use Case

We need to specify this without using escape hatches.

Proposed Solution

No response

Other Information

No response

Acknowledgements

CDK version used

2.82.1

Environment details (OS name and version, etc.)

macOS Ventura 13.3.1

peterwoodworth commented 1 year ago

Adding this here for clarity without having to check the other thread: We don't provide an option to set this with the new writer/reader API. Will need to use escape hatches in the meantime to add this prop

We accept contributions, adding this prop should be pretty easy 🙂

github-actions[bot] commented 1 year ago

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.

peterwoodworth commented 1 year ago

@argarinpauljohn was there any reason you closed this?

argarinpauljohn commented 1 year ago

Oh sorry @peterwoodworth! Mistakenly closed this one. I won't have time to work on this at the moment though.

corymhall commented 1 year ago

@argarinpauljohn based on the docs this property is not actually used for aurora clusters.

Amazon Aurora Not applicable. When you delete a DB cluster, all automated backups for that DB cluster are deleted and can't be recovered. Manual DB cluster snapshots of the DB cluster are not deleted.