aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code
https://aws.amazon.com/cdk
Apache License 2.0
11.71k stars 3.94k forks source link

EFS: Provide name for access point #26745

Open Balaji-JBC opened 1 year ago

Balaji-JBC commented 1 year ago

Describe the feature

There should be a possibility to provide access point name for the created efs access point

Use Case

Currently we can provide the name tag to the efs access point to easily identify it. however the name property should be definable when creating the access point itself

Proposed Solution

add attribute called access_point_name to add_access_point function in FileSystem class

Other Information

No response

Acknowledgements

CDK version used

2.63.2

Environment details (OS name and version, etc.)

macOS Ventura 13.4.1

pahud commented 1 year ago

That makes sense but there's no relevant property to specify access point name in CFN https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-efs-accesspoint.html

Have you tried to assign a name tag for it instead?

peterwoodworth commented 1 year ago

Either this is supported through tags (which I am pretty sure it is), or you should create an issue at the CloudFormation Coverage Roadmap repository if one doesn't already exist

Balaji-JBC commented 1 year ago

Hello, Tags doesn't seem to create any effect on this. for example

`
efs_access_point = efs_file_system.add_access_point('access_point_id')

    Tags.of(efs_access_point).add(key='Name', value='efs_access_point_name')

` didn't create any impact on the name tag of the access point

amitsmlaws commented 8 months ago

Updating tags, works okay.