search

aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code
https://aws.amazon.com/cdk
Apache License 2.0
11.67k stars 3.92k forks source link

aws-ec2: flow logs for TransitGateway & TransitGatewayAttachment #27222

Closed juweeks closed 9 months ago

juweeks commented 1 year ago

Describe the feature

TransitGateway and TransitGatewayAttachment resource types are missing from FlowLogResourceType

Use Case

add flow logs to Transit Gateway resources

Proposed Solution

for FlowLogResourceType, add from_transit_gateway_id and from_transit_gateway_attachement_id methods

Other Information

No response

Acknowledgements

CDK version used

2.91

Environment details (OS name and version, etc.)

mac ventura 13.5.2

khushail commented 1 year ago

Hi @juweeks , thanks for reaching out. Yes, it would be helpful to have these methods in FlowlogsResourceType

dyoshikawa commented 1 year ago

I'll work on it.

dyoshikawa commented 1 year ago

I've implemented it. Could you review?

github-actions[bot] commented 9 months ago

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.