aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code
https://aws.amazon.com/cdk
Apache License 2.0
11.58k stars 3.88k forks source link

(appconfig): Linter errors must be audited #27894

Closed kaizencc closed 8 months ago

kaizencc commented 11 months ago

Describe the bug

AppConfig L2 in alpha stage was released without the linter checker turned on, so none of these linter exceptions have been audited. These rules likely should be fixed rather than exempted, which could result in breaking changes. Marking this as a p1 because this issue should block any potential graduation of the AppConfig module.

As seen in the awslint.json file:

{
        "no-unused-type:@aws-cdk/aws-appconfig-alpha.PredefinedDeploymentStrategyId",
        "ref-via-interface:@aws-cdk/aws-appconfig-alpha.Application.addAgentToEcs.taskDef",
        "props-physical-name:@aws-cdk/aws-appconfig-alpha.ApplicationProps",
        "props-physical-name:@aws-cdk/aws-appconfig-alpha.DeploymentStrategyProps",
        "props-physical-name:@aws-cdk/aws-appconfig-alpha.EnvironmentProps",
        "props-physical-name:@aws-cdk/aws-appconfig-alpha.ExtensionProps",
        "events-in-interface",
        "events-method-signature",
        "events-generic"
}

Expected Behavior

No linter errors

Current Behavior

Linter rules are being exempted

Reproduction Steps

n/a

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.100.0

Framework Version

No response

Node.js Version

20

OS

Mac

Language

TypeScript

Language Version

No response

Other information

No response

github-actions[bot] commented 8 months ago

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.