search

aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code
https://aws.amazon.com/cdk
Apache License 2.0
11.66k stars 3.92k forks source link

pipeline: should allow crossRegionReplicationBuckets passthrough to underlying CodePipeline construct #28446

Closed ahammond closed 10 months ago

ahammond commented 10 months ago

Describe the feature

When deploying large numbers of CdkPipelines, we consume a lot of S3 buckets. There is already a way to reuse the artifact buckets across multiple CdkPipelines. We would like to also reuse the cross region replication buckets. To do this, we need to pass through the crossRegionReplicationBuckets property from the Pipeline object to the internal CodePipeline object.

Use Case

There's a hard limit of 1000 S3 buckets per account. Our CdkPipelines deployer account supports pipelines from roughly 130 repos at this time and recently crossed the 900 bucket line. We need to be able to keep scaling out.

Proposed Solution

Pass the crossRegionReplicationBuckets through, same has how reuseCrossRegionSupportStacks is passed through: https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/pipelines/lib/codepipeline/codepipeline.ts#L458

Other Information

No response

Acknowledgements

CDK version used

2.115.0

Environment details (OS name and version, etc.)

irrelevant

khushail commented 10 months ago

@ahammond ,thanks for submitting the FR and your contribution on PR.

github-actions[bot] commented 10 months ago

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.