search

aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code
https://aws.amazon.com/cdk
Apache License 2.0
11.72k stars 3.94k forks source link

(neptune-alpha): Verification of matching engineVersion and parameterGroup version #28651

Open badmintoncryer opened 10 months ago

badmintoncryer commented 10 months ago

Describe the feature

Verifies whether the parameterGroupFamily set corresponds to the specified engineVersion.

Use Case

In Neptune, there are engine versions such as 1.0 series, 1.2 series, and 1.3 series, and it's necessary to set the corresponding version of the parameterGroupFamily for these engines. For instance, if you set a v1.0 parameterGroupFamily for a cluster with an engineVersion in the v1.2 series, an error will occur during deployment.

aws-cdk-neptune-integ | 24/33 | 1:49:54 AM | CREATE_FAILED        | AWS::Neptune::DBCluster               | Database (DatabaseB269D8BB) Resource handler returned message: "The Parameter Group paramsa8366201-js9btllrt8cs with DBParameterGroupFamily neptune1 cannot be used for this instance. Please use a Parameter Group with DBParameterGroupFamily neptune1.2 (Service: Neptune, Status Code: 400, Request ID: 2c609029-86e7-432c-aac7-5b39623c054c)" (RequestToken: 293c5e39-f5d4-16cf-8e8d-770ce94aab37, HandlerErrorCode: InvalidRequest)

I would like to make these errors detectable at the time of running cdk synth.

Proposed Solution

No response

Other Information

https://docs.aws.amazon.com/neptune/latest/userguide/parameter-groups.html

Acknowledgements

CDK version used

2.116.1

Environment details (OS name and version, etc.)

irrelevant

pahud commented 10 months ago

Yes we should add the validations in CDK.