aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code
https://aws.amazon.com/cdk
Apache License 2.0
11.5k stars 3.84k forks source link

ApplicationLoadBalancedFargateService : Add Support for IPv6 on LB's #29039

Closed jlouk closed 1 week ago

jlouk commented 7 months ago

Describe the feature

I would like to enable IPv6 support on the load balancers created by ApplicationLoadBalancedFargateService and ApplicationLoadBalancedEc2Service.

Ideally this could be used as a new property for these two classes.``

Use Case

With the introduction of AWS charging for public IPv4 addresses (source), I am looking to enable IPv6 addresses on my ECS ALBs.

Proposed Solution

In the elbv2.ApplicationLoadBalancer class, there is a property for ipv6:

new elbv2.ApplicationLoadBalancer(stack, 'ALB', {
  vpc,
  internetFacing: true,
  ipAddressType: elbv2.IpAddressType.DUAL_STACK,
});

My proposal would be to add the property ipAddressType to ApplicationLoadBalancedFargateService and ApplicationLoadBalancedEc2Service with the corresponding actions to enable when necessary. The default would be elbv2.IpAddressType.IPV4 which would make this an opt-in service.

Other Information

No response

Acknowledgements

CDK version used

2.126.0

Environment details (OS name and version, etc.)

MacOS Monterey 12.7

pahud commented 7 months ago

We welcome the PRs and before that I guess we could always doing escape hatches using addPropertyOverride() to achieve that.

jmnarloch commented 2 months ago

@pahud Do you think you could review the Application Load Balancer PR(https://github.com/aws/aws-cdk/pull/30089#issuecomment-2201231428)? I would like to enable IPv6 Load Balancer in my production stack. I can also give the PR a first review.

pahud commented 1 month ago

@jmnarloch I've escalated this PR review to the team. The maintainer should take a look shortly. Thank you for letting me know.

github-actions[bot] commented 1 week ago

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

github-actions[bot] commented 1 week ago

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.