search

aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code
https://aws.amazon.com/cdk
Apache License 2.0
11.35k stars 3.77k forks source link

bedrock: L2 Constructs #29963

Open jlosito opened 2 months ago

jlosito commented 2 months ago

Describe the feature

I would like to use L2 constructs to provision Bedrock related resources with sensible defaults. Now that L1 constructs have been added via https://github.com/aws/aws-cdk/pull/29911 , this should be possible now!

Use Case

I have been using the awslabs/generative-ai-cdk-constructs library to provision and configure Bedrock related resources, but this library makes use of custom resources to perform all of its actions. I much rather use native constructs rather than custom resources.

https://github.com/awslabs/generative-ai-cdk-constructs

Proposed Solution

If possible, use the same defaults that the generative-ai-cdk-constructs library is using for each of its L2-like constructs. In my opinion, this would make it a little bit easier to users to migrate without having to change too much. If not, that's fine too.

Other Information

No response

Acknowledgements

CDK version used

2.139.0

Environment details (OS name and version, etc.)

macOS 14.4.1

pahud commented 2 months ago

Absolutely. Please help us prioritize with 👍 .

hoegertn commented 2 months ago

If somebody from the community wants to pick it up, that is exactly what https://www.open-constructs.org/ is for.

badmintoncryer commented 1 month ago

There is a Bedrock L2 construct at awslabs/generative-ai-cdk-constructs.

jlosito commented 1 month ago

@badmintoncryer those are all using custom resources. It would be better if they were using leveraging the L1 constructs instead that were just introduced within the last month.

badmintoncryer commented 1 month ago

@jlosito It's true. But a PR using L1 has been created. It seems it will be replaced soon. https://github.com/awslabs/generative-ai-cdk-constructs/pull/414

dirkmichelmycomosi commented 1 month ago

Yes please, absolutely. Currently working with the L1s and the L2s would definitely help increase productivity.

laithalsaadoon commented 1 month ago

https://github.com/awslabs/generative-ai-cdk-constructs/pull/414 was merged today

krokoko commented 1 month ago

@pahud @paulhcsun we did look at the contribution guide and design guidelines to contribute to the CDK our existing L2 bedrock construct mentioned above (and maybe more). We will have some changes to do to follow the guidelines, in the meantime should we open a new GitHub issue to track this effort ? Is there anything else we should do to ? Thanks !