search

aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code
https://aws.amazon.com/cdk
Apache License 2.0
11.5k stars 3.84k forks source link

aws-eks: `addAutoScalingGroupCapacity` lacks support for Amazon Linux 2023 #29983

Open isker opened 4 months ago

isker commented 4 months ago

Describe the feature

addAutoScalingGroupCapacity allows the user to select a MachineImageType, but this only includes AL2 or Bottlerocket. AL2023 is missing.

https://github.com/aws/aws-cdk/blob/v2.139.0/packages/aws-cdk-lib/aws-eks/lib/cluster.ts#L2468-L2480

Use Case

I want to use a newer kernel than is available in AL2 on my EKS ASGs.

Proposed Solution

No response

Other Information

AL2023 support has been added for managed node groups but not for ASGs. See #29546 #29334. cc @pahud as you've handled those issues.

Acknowledgements

CDK version used

2.139.0

Environment details (OS name and version, etc.)

N/A

pahud commented 4 months ago

Yes we could have a PR for that. But I am wondering why you opt in addAutoScalingGroupCapacity rather than addNodeGroupCapacity? Is there any feature not supported in the managed nodegroups?

isker commented 4 months ago

https://github.com/aws/containers-roadmap/issues/608

pahud commented 4 months ago

@isker Is it because Nodegroup currently does not support tagging ASG? This would be a huge tradeoff. In CDK, you still can create a managed nodegroup and a custom resource to tag the ASG behind the nodegroup. Would this be something you expect?

check https://github.com/aws/aws-cdk/issues/29280#issuecomment-1967683280 and https://github.com/aws/aws-cdk/issues/29280#issuecomment-1971460918

Feel free to chat with me on cdk.dev if you need.

isker commented 4 months ago

Thanks for that information. I'll take a look.

CDK should support AL2023 on EKS ASGs.

awsdataarchitect commented 3 months ago

Similar issue exists on eks blueprints #1006