search

aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code
https://aws.amazon.com/cdk
Apache License 2.0
11.5k stars 3.84k forks source link

aws_ec2.VpcEndpointService: Modify endpoint acceptance setting #30192

Closed pguthinabail closed 1 month ago

pguthinabail commented 3 months ago

Describe the feature

When creating an Endpoint service using aws_ec2.VpcEndpointService, the acceptance_required field can be set. But, there is no method to update this flag after the endpoint service has been created. It is possible to modify this setting in console as well as the lower level construct aws_ec2.CfnVPCEndpointService. ``

Use Case

Adding this feature in aws_ec2.VpcEndpointService will bring it to the level of console and lower level construct. With this feature, I can disable it in CDK for a short time to add intended connections and enable it again for security. Currently, someone with admin privileges need to monitor the console for requests, accept it manually and then ket the deployment continue which adds unnecessary overhead to automating the process.

Proposed Solution

Add a method to toggle the flag acceptance_required for Endpoint services created using the construct aws_ec2.VpcEndpointService

Other Information

No response

Acknowledgements

CDK version used

2.88.0

Environment details (OS name and version, etc.)

MacOS 14.3

khushail commented 3 months ago

Hi @pguthinabail , thanks for creating this feature request. Please feel free to submit a PR. Here is a contribution guide to get started. however Contributions from the community are welcome!

Leo10Gama commented 1 month ago

Closing this issue as, unfortunately, we cannot accept changes like this. By allowing this value to be altered later in execution, it becomes unclear what the source of truth is for this property. There isn't a good enough reason to change the value outside of the constructor, and while adding in this functionality would cover a few specific use cases of toggling it off and on to add connections, it would ultimately degrade the user experience overall.

github-actions[bot] commented 1 month ago

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.