search

aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code
https://aws.amazon.com/cdk
Apache License 2.0
11.51k stars 3.85k forks source link

dms: CfnDataProviderProps is missing the 'Settings' field of AWS::DMS::DataProvider. #30224

Open stowns opened 4 months ago

stowns commented 4 months ago

Describe the bug

CfnDataProviderProps is missing the 'Settings' field of AWS::DMS::DataProvider.

Expected Behavior

I would expect CfnDataProviderProps to include a settings property for configuring database properties ie)

"Settings": {
    "DocDbSettings": {
        "ServerName": "my-server-name",
        "Port": 27017,
        "DatabaseName": "docdb",
        "SslMode": "require"
    }
}

Current Behavior

There is no settings property of the CfnDataProviderProps construct

Reproduction Steps

new CfnDataProvider(this, 'my-data-provider', {
  // try to add 'settings'
})

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.141.0

Framework Version

No response

Node.js Version

18.18.0

OS

MacOS 14.4.1

Language

TypeScript

Language Version

No response

Other information

No response

ashishdhingra commented 4 months ago

Reproducible.

The CFN Schema at https://github.com/cdklabs/awscdk-service-spec/commits/main/sources/CloudFormationSchema/us-east-1/aws-dms-dataprovider.json appears to be have Settings as one of the properties for AWS::DMS::DataProvider. This is in sync with https://d1uauaxba7bl26.cloudfront.net/latest/gzip/CloudFormationResourceSpecification.json.

Needs review with the team.

EDIT: Looks like it was removed as part of PR https://github.com/cdklabs/awscdk-service-spec/pull/1050.

PR https://github.com/aws/aws-cdk/pull/30182 should add Settings as property for AWS::DMS::DataProvider, once merged.