search

aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code
https://aws.amazon.com/cdk
Apache License 2.0
11.33k stars 3.76k forks source link

aws-ecs: `ContainerImage.fromEcrRepository` should be `tagOrDigest` #30463

Open cheruvian opened 3 weeks ago

cheruvian commented 3 weeks ago

Describe the issue

The underlying EcrImage constructor has the correct naming tagOrDigest since most use the helper static method the name and documentation should be updated there is as well.

https://github.com/aws/aws-cdk/blob/v2.144.0/packages/aws-cdk-lib/aws-ecs/lib/images/ecr.ts#L22

Links

https://github.com/aws/aws-cdk/blob/v2.144.0/packages/aws-cdk-lib/aws-ecs/lib/container-image.ts#L22 https://github.com/aws/aws-cdk/blob/v2.144.0/packages/aws-cdk-lib/aws-ecs/lib/images/ecr.ts#L22

pahud commented 3 weeks ago

Yes, but I am not sure how to fix that without breaking changes. Any ideas?

cheruvian commented 1 day ago

Looks like it's a positional argument not a named one, so shouldn't be a breaking change? (unless this is some breaking change quirk of JSII?)