feat(apigatewayv2-integrations): `WebSocketMockIntegration` props

aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code

https://aws.amazon.com/cdk

Apache License 2.0

11.55k stars 3.87k forks source link

feat(apigatewayv2-integrations): `WebSocketMockIntegration` props #30622

Open nmussy opened 3 months ago

nmussy commented 3 months ago

Issue # (if applicable)

None

Reason for this change

Unlike the other integrations, WebSocketMockIntegration did not have a props interface, and was missing a few properties. This PR does not include integration responses, they are already being implemented in #29661

Description of changes

Added requestTemplates and templateSelectionExpression to the newly created WebSocketMockIntegrationProps

Description of how you validated changes

Unit and integration tests were updated

Checklist

[x] My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

nmussy commented 3 months ago

Exemption Request: WebSocketMockIntegration is currently not mentioned in any README file

aws-cdk-automation commented 3 months ago

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 24dde442e9c7f8fc2a511c984abdafec858cf6f5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

GavinZZ commented 1 month ago

Exemption Request: WebSocketMockIntegration is currently not mentioned in any README file

I don't think this is a good enough reasoning. Some documentation should have been added when this construct is initially added. Would you please add somethiing to the README to explain the usage and what this is for? Appreciate it.

aws-cdk-automation commented 1 month ago

The pull request linter fails with the following errors:

❌ Features must contain a change to a README file.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

✅ A exemption request has been requested. Please wait for a maintainer's review.

aws-cdk-automation commented 1 month ago

The pull request linter fails with the following errors:

❌ Features must contain a change to a README file.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

✅ A exemption request has been requested. Please wait for a maintainer's review.