search

aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code
https://aws.amazon.com/cdk
Apache License 2.0
11.55k stars 3.87k forks source link

feat(events): dead letter queue for an Event Bus #30628

Open badmintoncryer opened 3 months ago

badmintoncryer commented 3 months ago

Issue # (if applicable)

Closes #30531.

Reason for this change

EventBus L2 construct doesn't support for configuring dead letter queue.

Description of changes

Add deadLetterQueue prop to EventBusProps

Description of how you validated changes

Add both unit and integ test

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

msambol commented 3 months ago

Small nits re: the naming, otherwise LGTM.

badmintoncryer commented 3 months ago

@msambol Thank you for your review!! I've addressed your comments.

aws-cdk-automation commented 2 months ago

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

aws-cdk-automation commented 1 month ago

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

aws-cdk-automation commented 1 month ago

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

aws-cdk-automation commented 1 month ago

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

badmintoncryer commented 1 month ago

@msambol Hi, I've fixed this PR. Could you please re-review this?

aws-cdk-automation commented 1 month ago

AWS CodeBuild CI Report

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository