aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code
https://aws.amazon.com/cdk
Apache License 2.0
11.33k stars 3.76k forks source link

fix(scheduler-targetes-alpha): multiple schedules cause resolution error during synth #30634

Open Tietew opened 4 days ago

Tietew commented 4 days ago

Reason for this change

Creating multiple Schedules causes Resolution Error during synth. This PR does not fix the root cause (discussing at #28713), but apply a workaround to prevent the error.

Description of changes

Use ServicePrincipal with conditions directly, instead of PrincipalWithConditions.

Description of how you validated changes

Added a feature flag {"@aws-cdk/aws-iam:minimizePolicies":true} to unit tests. Resolution errors occur before fix. No errors occur after fix.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

aws-cdk-automation commented 3 days ago

AWS CodeBuild CI Report

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository