Closed badmintoncryer closed 2 days ago
@GavinZZ Thank you for your review! I've addressed your comments.
I'll update snapshot files later
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).
Issue # (if applicable)
None
Reason for this change
Deployment group supports a termination hook for EC2 compute type but CDK L2 construct does not support this.
Description of changes
Added
terminationHook
toServerDeploymentGroupProps
Description of how you validated changes
Added both unit and integ tests
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license