feat(eks): support CUSTOM amiType - Githubissues

aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code

https://aws.amazon.com/cdk

Apache License 2.0

11.55k stars 3.87k forks source link

feat(eks): support CUSTOM amiType #30660

Open Artemigos opened 3 months ago

Artemigos commented 3 months ago

Issue # (if applicable)

Closes #30641.

Reason for this change

Node groups with custom AMI are supported by CloudFormation, but not by CDK. This adds that support.

Description of changes

added CUSTOM to the NodegroupAmiType enum
always add CUSTOM to possibleAmiTypes when validating instanceTypes CPU architecture against amiType
verify that launchTemplateSpec is defined when using CUSTOM

Description of how you validated changes

Added unit tests checking valid deployment as well as failure when CUSTOM is used, but launchTemplateSpec isn't defined.

Checklist

[x] My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

aws-cdk-automation commented 1 month ago

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 432ead4c4c5786a379005f5bd08f0ee8d5b2d58d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository