search

aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code
https://aws.amazon.com/cdk
Apache License 2.0
11.33k stars 3.76k forks source link

feat(route53): added EvaluateTargetHealth to Route53 Alias targets (#9481) #30664

Open wladyslawczyzewski opened 2 days ago

wladyslawczyzewski commented 2 days ago

Issue # (if applicable)

Part of a bigger piece of work for #9481

Reason for this change

At this moment constructing the Route53 health checks is available only via L1 construct, this PR is one of the series to introduce the R53 health checks via higher-level constructs.

Description of changes

The underlying L1 construct of a few L2 constructs for Alias targets already has the EvaluateTargetHealth property, so by adding this prop to the L2 construct we get the quick win to introduce the health checks for Alias records.

Description of how you validated changes

Uni tests included.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

wladyslawczyzewski commented 2 days ago

hey guys, this is my first contribution to this repo, I would be grateful for any feedback 🤝

aws-cdk-automation commented 2 days ago

AWS CodeBuild CI Report

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository