search

aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code
https://aws.amazon.com/cdk
Apache License 2.0
11.55k stars 3.87k forks source link

Update cdk.template.json to include *.go files. #30667

Closed jeremyforan closed 3 months ago

jeremyforan commented 3 months ago

The default template for cdk Go apps, cdk.json uses go run %name%.go to initiate the app. The default should be changed to include multiple .go files by default.

Reason for this change

cdk.template.json should include all go files in the cdk directory. This is more consistant with most Go projects and allows for the cdk code to be organized into different files by default.

Description of changes

The change is small but, I believe it is what most go developers would expect when running the default project template.

{
  "app": "go mod download && go run %name%.go",
  // ...
}

to 

{
  "app": "go mod download && go run .",
  // ...
}

Description of how you validated changes

I have run and tested the change in my environment.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

aws-cdk-automation commented 3 months ago

Your pull request must be based off of a branch in a personal account (not an organization owned account, and not the main branch). You must also have the setting enabled that allows the CDK team to push changes to your branch (this setting is enabled by default for personal accounts, and cannot be enabled for organization owned accounts). The reason for this is that our automation needs to synchronize your branch with our main after it has been approved, and we cannot do that if we cannot push to your branch.

aws-cdk-automation commented 3 months ago

The pull request linter fails with the following errors:

❌ The title of this pull request does not follow the Conventional Commits format, see https://www.conventionalcommits.org/.
❌ Pull requests from `main` branch of a fork cannot be accepted. Please reopen this contribution from another branch on your fork. For more information, see https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md#step-4-pull-request.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

aws-cdk-automation commented 3 months ago

Your pull request must be based off of a branch in a personal account (not an organization owned account, and not the main branch). You must also have the setting enabled that allows the CDK team to push changes to your branch (this setting is enabled by default for personal accounts, and cannot be enabled for organization owned accounts). The reason for this is that our automation needs to synchronize your branch with our main after it has been approved, and we cannot do that if we cannot push to your branch.

aws-cdk-automation commented 3 months ago

AWS CodeBuild CI Report

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository