aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code
https://aws.amazon.com/cdk
Apache License 2.0
11.5k stars 3.84k forks source link

aws_lambda: npm package js not synced with ts #30908

Open bataras opened 1 month ago

bataras commented 1 month ago

Describe the bug

  1. download the release aws-cdk-2.149.0.zip
  2. extrace js/aws-cdk-lib@2.149.0.jsii.tgz
  3. these two files don't seem to be in sync...

The TS file has..

export declare class DockerImageFunction extends Function {
    constructor(scope: Construct, id: string, props: DockerImageFunctionProps);
}

The JS file has a version of this: https://github.com/aws/aws-cdk/blob/87139ab2eeae96df9d775118b870cfb326438197/packages/aws-cdk-lib/aws-lambda/lib/image-function.ts#L66

export class DockerImageFunction extends Function {
  constructor(scope: Construct, id: string, props: DockerImageFunctionProps) {
    super(scope, id, {
      ...props,
      handler: Handler.FROM_IMAGE,
      runtime: Runtime.FROM_IMAGE,
      code: props.code._bind(props.architecture),
    });
  }

Expected Behavior

files are in sync

Current Behavior

they are not in sync

Reproduction Steps

see description

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.149.0

Framework Version

No response

Node.js Version

v22.0.0

OS

macos

Language

TypeScript

Language Version

No response

Other information

No response

pahud commented 1 month ago

Can you explain what issues are you having using lambda.DockerImageFunction construct ?

bataras commented 1 month ago

There are no apparent issues running it.