aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code
https://aws.amazon.com/cdk
Apache License 2.0
11.5k stars 3.85k forks source link

Pipelines: CodeStar Connections is now CodeConnections #31029

Open zaq42 opened 1 month ago

zaq42 commented 1 month ago

Describe the issue

Documentation for CodePipelineSource.connection says:

To use this method, you first need to create a CodeStar connection using the AWS console

The term "CodeStar connection" is confusing, since AWS CodeStar is now deprecated.

On July 31, 2024, Amazon Web Services (AWS) will discontinue support for creating and viewing AWS CodeStar projects.

However, what is needed is now under AWS CodeConnections (ref)

Posted On: Mar 29, 2024 AWS is renaming AWS CodeStar Connections to AWS CodeConnections.

Links

https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.pipelines.CodePipelineSource.html#static-connectionrepostring-branch-props

ashishdhingra commented 1 month ago

Findings:

To update references in documentation, it is not required to change the ARN in the example.

There are also references to CodeStar Connections in Readme.

Also, although this appears to be a documentation only change, we still have codestar-connections in https://github.com/aws/aws-cdk/tree/main/packages/aws-cdk-lib/aws-codepipeline-actions/lib. CDK should deprecate that as well (at least to offer a new class). Needs discussion with the team.

ashishdhingra commented 1 month ago

For now, we should update the Readme and API documentation string to mention about deprecation.