aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code
https://aws.amazon.com/cdk
Apache License 2.0
11.51k stars 3.85k forks source link

neptune: specify port for the cluster #31074

Closed badmintoncryer closed 1 week ago

badmintoncryer commented 1 month ago

Describe the feature

Specify port number of the Neptune cluster.

Use Case

We can configure the port number of Neptune cluster but CDK L2 construct cannot configure this.

Proposed Solution

Add port property to DatabaseClusterProps and set DBPort to the port value. https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-neptune-dbcluster.html#cfn-neptune-dbcluster-dbport

Other Information

No response

Acknowledgements

CDK version used

2.150.0

Environment details (OS name and version, etc.)

irrelevant

ashishdhingra commented 1 month ago

Looking at DatabaseClusterProps, there appears to be no property that maps to DBPort. However, per AWS::Neptune::DBCluster appears to be supported property (there is also Port property, however, there is a note that This property will soon be deprecated. Please update existing templates to use the new DBPort property that has the same functionality.).

@badmintoncryer Thanks for submitting the feature request. Kindly note that aws-neptune-alpha is an experimental L2 construct as of now, so we encourage community to submit updates to this construct package. Feel free to submit PR that could be reviewed by the team.

Thanks, Ashish

github-actions[bot] commented 1 week ago

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

github-actions[bot] commented 1 week ago

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.