aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code
https://aws.amazon.com/cdk
Apache License 2.0
11.52k stars 3.86k forks source link

cdk-lib/aws-stepfunction-tasks: step-function invoke not receiving integrationPatterns properly #31401

Closed harelfar2 closed 1 week ago

harelfar2 commented 1 week ago

Describe the bug

when calling StepFunctionsStartExecution, the parameter: integrationPattern doesn't seem to affect.

Regression Issue

Last Known Working CDK Version

No response

Expected Behavior

When I run it with: integrationPattern: sfn.IntegrationPattern.REQUEST_RESPONSE, I expect it to work in sync mode.

Current Behavior

When I run it with: integrationPattern: sfn.IntegrationPattern.REQUEST_RESPONSE, It works in asynchronous mode.

Reproduction Steps

Define a parent state machine. Define a child state machine. call the child from the parent with: const childSfn = new tasks.StepFunctionsStartExecution(this, "name", { stateMachine: childStateMachine, integrationPattern: sfn.IntegrationPattern.REQUEST_RESPONSE, })

Possible Solution

From looking at file: packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/stepfunctions/start-execution.ts I see that integrationPattern is a private field. it should be in props.

CDK CLI Version

2.157.0

Framework Version

No response

Node.js Version

20.4.10

OS

Windows

Language

TypeScript

Language Version

No response

Other information

No response

github-actions[bot] commented 1 week ago

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.