aws / aws-cdk

The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code
https://aws.amazon.com/cdk
Apache License 2.0
11.55k stars 3.87k forks source link

fix(route53-targets): deprecated method for dns name is used in userpool domain target (under feature flag) #31403

Open go-to-k opened 2 weeks ago

go-to-k commented 2 weeks ago

WIP: waiting for the PR to be merged.

Reason for this change

The PR created a new method to get CloudFront DNS name in Cognito user pool domain. A custom resource is created in the old method, but is not in the new method.

However, the UserPoolDomainTarget in the route53-targets module continues to use the old method. So we should change to use the new method.

Description of changes

The bind method in the UserPoolDomainTarget implements IAliasRecordTarget interface, so a new method instead of the bind cannot be created.

Therefore, I take it using a feature flag.

Description of how you validated changes

Both unit and integ tests.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

aws-cdk-automation commented 5 days ago

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

aws-cdk-automation commented 1 day ago

AWS CodeBuild CI Report

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository