Open go-to-k opened 2 weeks ago
This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
WIP: waiting for the PR to be merged.
Reason for this change
The PR created a new method to get CloudFront DNS name in Cognito user pool domain. A custom resource is created in the old method, but is not in the new method.
However, the
UserPoolDomainTarget
in theroute53-targets
module continues to use the old method. So we should change to use the new method.Description of changes
The
bind
method in theUserPoolDomainTarget
implementsIAliasRecordTarget
interface, so a new method instead of thebind
cannot be created.Therefore, I take it using a feature flag.
Description of how you validated changes
Both unit and integ tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license