Closed kaizencc closed 1 week ago
:arrow_right: PR build request submitted to test-main-pipeline
:arrow_left:
A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested
label once the pipeline succeeds.
I mean cdk.json
, sorry. Although all places we add context goes into the same Configuration
object so in theory it should work for both cdk.json
and cdk.context.json
.
The only other place in cli.ts where I see two ways of describing the same thing is here:
case 'synth':
const quiet = configuration.settings.get(['quiet']) ?? args.quiet;
and it is in fact defaulting to the opposite. But this line was written by a community contributor and it doesn't look like that decision was made with any intentionality (and in fact maybe was done to make testing easier). I think we should default to command line arguments before context values and would support switching the quiet
logic around also.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.
closes #28249.
The qualifier property can be set via the context key "@aws-cdk/core:bootstrapQualifier" and if omitted, the arbitrary default is
hnb659fds
. In the case ofcdk bootstrap
, there is an additional way to set the qualifier via the--qualifier
CLI option. Specific to thecdk bootstrap
logic, we currently only honor the command line argument, which is an error.Ultimately, the following
cdk bootstrap
calls should be identical:cdk bootstrap
with the followingcdk.json
file:cdk bootstrap --qualifier="abcde"
I've made the decision that the
--qualifier
parameter takes precedent over thecdk.json
context if they are both set.