aws-cdk-automation
commented
2 weeks ago The pull request linter fails with the following errors:
❌ Fixes must contain a change to an integration test file and the resulting snapshot.PRs must pass status checks before we can provide a meaningful review.
If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.
Issue # (if applicable)
Closes #31303.
Reason for this change
During the update S3 bucket notifications, if there are multiple filter rules involved, the order of filter rules is different from CFN event notifications and S3 get notifications call. This will result different hash value which makes CDK unable to recognize s3 notifications created by the stack itself.
Description of changes
Sort the notifications filter rules by key when calculating the hash value.
Description of how you validated changes
Manually tested and integration tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license